-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move non-deps and shared UI code in shared folder #9350
Conversation
3722992
to
ebde744
Compare
0de938b
to
333e2c0
Compare
333e2c0
to
4ffb4e3
Compare
4ffb4e3
to
208e79e
Compare
208e79e
to
795ca51
Compare
795ca51
to
875284e
Compare
I will push commit by commit to check if each commit (except the a few) builds on Windows and macOS. |
875284e
to
769d869
Compare
4295dab
to
71ea0b1
Compare
The result of the discussion boiled down to "we're not entirely happy with 'shared' but also haven't come up with a compelling alternative". Also given that it should be trivial to change this later, we didn't necessarily wanted to block the PR over it. |
89d4ca0
to
0254dc0
Compare
28f9b5a
to
a245cfc
Compare
a245cfc
to
afe4395
Compare
afe4395
to
cd401a2
Compare
cd401a2
to
46e47c0
Compare
46e47c0
to
e80588e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and @PatTheMav has said off-thread that this is fine as-is. Neither of us have come up with a preferred alternative to "shared", so "shared" it will be. Rebase this and I'll use a merge commit.
The remaining files are only used by the UI, so those are restored in the obs-studio target
e80588e
to
4214050
Compare
Description
deps
folder to theshared
foldershared
folderFind Qt with versionless removed to avoid this issue on Ubuntu CI:(fixed)Motivation and Context
Based on ideas from this #9220 (comment)
How Has This Been Tested?
Types of changes
Checklist: